Issue #530: host OpenSans font ourselves #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalchevrel
changed the title
|
|
||
| @font-face { | ||
| font-family: 'Open Sans'; | ||
| font-family: 'Open Sans Light'; | ||
| src: url('/fonts/OpenSans/OpenSans-Light-webfont.woff') format('woff'); |
There was a problem hiding this comment.
I'd remove quotes on the URLs for consistency with the rest of the CSS.
|
Besides the question about .htaccess, looks great to me 👍 |
* Don't provide fallbacks for old browsers, just use woff * Cache them via .htaccess * Put them in a local fonts folder A quick check on my local instance gives good results on page load (/3)
pascalchevrel
force-pushed
the
issue530_host_OpenSans
branch
from
b66a8c1
to
a40d1e8
Compare
pascalchevrel
added a commit
that referenced
this pull request
Nov 15, 2015
Issue #530: host OpenSans font ourselves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick check on my local instance gives good results on page load (/3)