Fix #721: Allow sorting columns in search results #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pascalchevrel
commented
Apr 13, 2016
pascalchevrel
commented
- clean up our code to always define additional css and js files in the dispatcher
- make tables in all views sortable except a couple were it didn't make sense (like a 3 rows table)
- update the select_column.js and its associated html to not conflict with sorttable.js on the click event
- fix naming of variables for consistency
|
By analyzing the blame information on this pull request, we identified @flodolo, @TheoChevalier and @tx2z to be potential reviewers |
|
@TheoChevalier ping |
| $page_descr = 'Create and download your own <abbr title="Translation Memory eXchange">TMX</abbr> file containing the strings you need.'; | ||
| $css_files[] = 'tmx.css'; | ||
| $js_files[] = '/js/select_all.js'; | ||
| $js_files[] = '/js/sorttable.js'; |
There was a problem hiding this comment.
I don’t think we need sorttable on this one
|
Looks like this one is missing? https://github.com/pascalchevrel/transvision/blob/721_sort_columns_main_view/app/controllers/showrepos.php#L5 |
* clean up our code to always define additional css and js files in the dispatcher * make tables in all views sortable except a couple were it didn't make sense (like a 3 rows table) * update the select_column.js and its associated html to not conflict with sorttable.js on the click event * fix naming of variables for consistency
pascalchevrel
force-pushed
the
721_sort_columns_main_view
branch
from
a24ac69
to
dd17cd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.