Skip to content
This repository has been archived by the owner on Mar 30, 2019. It is now read-only.

fix #822 Close menus when clicking off them #1158

Merged
merged 1 commit into from May 28, 2014

Conversation

ScottDowne
Copy link
Contributor

No description provided.

@ScottDowne
Copy link
Contributor Author

I had some issues with this, and the solution I came up with feels a little weird.

The polymer closeMenus function did not work well on a document event.

@simonwex simonwex added the Next label May 6, 2014
@secretrobotron secretrobotron added this to the Heartbeat 1: Post-All-Hands milestone May 7, 2014
@simonwex
Copy link
Member

@ScottDowne could you see if you're still proposing we merge this?

@ScottDowne
Copy link
Contributor Author

Small merge conflict, but trivial. This can now be looked at/merged.

The part I found to be weird is I could not use this inside the close menu function because sometimes it is a callback for window.onclick, which would mean this is actually window. So instead of this I used var userState = document.querySelector("user-state");

@simonwex simonwex assigned simonwex and unassigned ScottDowne May 16, 2014
@ScottDowne ScottDowne assigned Pomax and unassigned simonwex May 20, 2014
Pomax added a commit that referenced this pull request May 28, 2014
@Pomax Pomax merged commit daded8d into mozilla-appmaker:develop May 28, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants