This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 887700 - [OTA] [Data Migration] [Email] Cannot load email in Inbox after update from v1.0.1 to v1.1.0 #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x after update from v1.0.1 to v1.1.0
asutherland
added a commit
that referenced
this pull request
Jul 30, 2013
…email_in_Inbox_after_OTA_update Bug 887700 - [OTA] [Data Migration] [Email] Cannot load email in Inbox after update from v1.0.1 to v1.1.0. r=asuth
|
I am probably missing some background, but I would have liked to see a comment for this change at the least, as using == may be seen as an accidental typing mistake vs desired behavior. If the issue was that the value could have been undefined as well as null, perhaps a more explicit check for both values. If that is not possible, a comment at the very least of "yes, this is an intentional coercion" would be useful. I am concerned that when doing other large refactorings I may change this back to === to fix default jshint linter messages that show up in my editor. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After OTA updated, do an early return while the address pairs is null.