This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 803415 - Fix for MX lookup during autoconfig #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -988,7 +999,7 @@ Autoconfigurator.prototype = { | |||
| getConfig: function getConfig(userDetails, callback) { | |||
| let [emailLocalPart, emailDomainPart] = userDetails.emailAddress.split('@'); | |||
| let domain = emailDomainPart.toLowerCase(); | |||
| console.log('Attempting to get autoconfiguration for:'. domain); | |||
| console.log('Attempting to get autoconfiguration for', domain); | |||
There was a problem hiding this comment.
you're bit-rotting yourself! Also, that was a pretty cool typo on my part, eh?
|
r=asuth Hopefully this was the cause of most of our gmail user problems! |
jimporter
pushed a commit
that referenced
this pull request
Oct 29, 2012
Bug 803415 - Fix for MX lookup during autoconfig
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @asutherland
This PR fixes MX lookups, notably using lowercase for the domain we get back from MX and also trying to grab the config from the local file store first, which lets us use our special config files for Google (to make it use ActiveSync).
To make this work on Google Apps domains, just copy
apps/email/autoconfig/gmail.comtoapps/email/autoconfig/google.com. If you need an account on a Google Apps domain to test, I can forward you the auth details of the test account I was given.I'll issue the PR for gaia once this is merged.