Merge pull request #18842 from darchons/bug864395-the-i-want-to-help

Bug 864395 - Correctly test send perf data checkbox;
mozilla-b2g · May 7, 2014 · 8c2808c · 8c2808c
2 parents ca8eefa + 8d39344
commit 8c2808c
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/apps/settings/test/marionette/app/regions/improve.js b/apps/settings/test/marionette/app/regions/improve.js
@@ -59,9 +59,11 @@ ImprovePanel.prototype = {
   },
 
   enableSubmitPerfData: function() {
+    var initialState = this.isSubmitPerfData;
     this.waitForElement('submitPerfData').tap();
     this.client.waitFor(function() {
-      return this.isSubmitPerfData;
+      // Ensure tapping the element changed its state
+      return this.isSubmitPerfData !== initialState;
     }.bind(this));
   },