Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Commit

Permalink
Merge pull request #16974 from KevinGrandon/bug_946852_search_mode
Browse files Browse the repository at this point in the history
Bug 946852 - [Email] Search Mail field appears twice
  • Loading branch information
KevinGrandon committed Mar 16, 2014
2 parents 442c76c + 930eb81 commit 8f80223
Show file tree
Hide file tree
Showing 3 changed files with 60 additions and 0 deletions.
4 changes: 4 additions & 0 deletions apps/email/style/message_cards.css
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@
border-bottom: 0.1rem solid #bdbdbd;
}

[data-mode="search"] .msg-search-tease-bar {
display: none;
}

/* When card is slightly shown when folder card is center,
be sure any inputs do not accept clicks/taps that would
mess up the transition back to the message list. Also
Expand Down
24 changes: 24 additions & 0 deletions apps/email/test/marionette/lib/email.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,14 @@ var Selector = {
refreshButton: '.card.center .msg-refresh-btn',
messageHeaderItem: '.msg-messages-container .msg-header-item',
cardMessageReader: '.card-message-reader',
currentCardInputs: '.card.center input[type="text"]',
replyMenuButton: '.msg-reply-btn',
replyMenu: '.msg-reply-menu',
replyMenuReply: '.msg-reply-menu-reply',
replyMenuForward: '.msg-reply-menu-forward',
replyMenuAll: '.msg-reply-menu-reply-all',
searchButton: '.msg-search-btn',
searchCard: '.card[data-mode="search"]',
folderListButton: '.msg-list-header .msg-folder-list-btn',
settingsButton: '.fld-nav-toolbar .fld-nav-settings-btn',
settingsDoneButton: '.card-settings-main [data-l10n-id="settings-done"]',
Expand Down Expand Up @@ -338,6 +341,17 @@ Email.prototype = {
this._waitForTransitionEnd(cardId);
},

/**
* Returns the visible input elements for the current card.
*/
getVisibleCardInputs: function() {
var elements = this.client.findElements(Selector.currentCardInputs)
.filter(function(element) {
return element.displayed();
});
return elements;
},

saveLocalDrafts: function() {
this._waitForElementNoTransition(Selector.composeBackButton).tap();
this._waitForElementNoTransition(Selector.composeDraftSave).tap();
Expand Down Expand Up @@ -370,6 +384,16 @@ Email.prototype = {
.tap();
},

tapSearchButton: function() {
this.client.helper
.waitForElement(Selector.searchButton)
.tap();

this.client.helper
.waitForElement(Selector.searchCard);
this._waitForTransitionEnd('message_list');
},

waitForMessageList: function() {
this._waitForTransitionEnd('message_list');
},
Expand Down
32 changes: 32 additions & 0 deletions apps/email/test/marionette/search_test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
'use strict';

var Email = require('./lib/email');
var assert = require('assert');
var serverHelper = require('./lib/server_helper');

marionette('email message list edit mode', function() {
var app;

var client = marionette.client({
settings: {
// disable keyboard ftu because it blocks our display
'keyboard.ftu.enabled': false
}
});

var server = serverHelper.use(null, this);

setup(function() {
app = new Email(client);
app.launch();
app.manualSetupImapEmail(server);
});

test('only one input should appear', function() {
app.tapSearchButton();

var inputs = app.getVisibleCardInputs();
assert.equal(inputs.length, 1);
});

});

0 comments on commit 8f80223

Please sign in to comment.