Merge pull request #32335 from albertopq/1188350-title-window-open

Bug 1188350 - Setting title on popup windows r=etienne
mozilla-b2g · Oct 9, 2015 · a068470 · a068470
2 parents 0f8ea33 + 6b025e2
commit a068470
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/apps/system/js/popup_window.js b/apps/system/js/popup_window.js
@@ -88,6 +88,11 @@
    */
   PopupWindow.prototype.openAnimation = 'slide-from-bottom';
 
+  PopupWindow.prototype._handle_mozbrowsertitlechange = function(evt) {
+    this.name = evt.detail;
+    this.publish('namechanged');
+  };
+
   /**
    * Default closing animation.
    *

diff --git a/apps/system/test/unit/popup_window_test.js b/apps/system/test/unit/popup_window_test.js
@@ -110,4 +110,15 @@ suite('system/PopupWindow', function() {
     var popup = new PopupWindow(hiddenPopupConfig);
     assert.isTrue(popup.element.classList.contains('alwaysLowered'));
   });
+
+  test('Should replace the app name if the title changes', function() {
+    var name = 'testName';
+    var popup = new PopupWindow(fakePopupConfig);
+    this.sinon.stub(popup, 'publish');
+    assert.isFalse(popup.name === name);
+    var titleEvent = new CustomEvent('mozbrowsertitlechange', {detail: name});
+    popup.element.dispatchEvent(titleEvent);
+    assert.isTrue(popup.name === name);
+    assert.isTrue(popup.publish.calledWith('namechanged'));
+  });
 });