This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 890342 - [SMS] LinkHelper regression: misrecognized links #10844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var parts = domain.split('.'); | ||
| var lastPart = parts[parts.length - 1]; | ||
| // We want the last part not to be a number | ||
| return lastPart.length > 1 && isNaN(lastPart); |
There was a problem hiding this comment.
isNaN is not what you want here. For example isNaN('') is false :-)
I think you can try !isFinite(lastPart).
There was a problem hiding this comment.
Thanks for the tip!
I was checking the isFinite function and appreciated some nice behaviours:
isFinite(' 3 ') is true meanwhile isNaN(' 3 ') is false.
Anyway, as you comment, what we need here to ensure this works is !isFinite(lastPart)
|
Errors in travis are not related to this PR :( Merging |
arcturus
added a commit
that referenced
this pull request
Jul 9, 2013
Bug 890342 - [SMS] LinkHelper regression: misrecognized links
arcturus
added a commit
that referenced
this pull request
Jul 10, 2013
Bug 890342 - [SMS] LinkHelper regression: misrecognized links (cherry picked from commit 3ec4322)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.