Bug 910697 - Shows previous keyboard before displaying correct one #12473
Conversation
| delete this.ime.dataset.hidden; | ||
| this.ime.classList.remove('hide'); |
There was a problem hiding this comment.
It looks like the CSS file does not define a 'hide' class, so this line wasn't doing anything at all...
|
@janjongboom, you mentioned in the bugzilla issue that there is another bug that fixes the the flickering issue. If that bug is #12499 I'm not sure it addresses the flickering in this patch. That bugfix appears to work with the height of the keyboardFrameContainer while the flickering in this bug is caused by setting visibility hidden on ime element. If that is not the bug you were talking about feel free to ignore this comment. |
| }; | ||
|
|
||
| var hideIME = function km_hideIME() { | ||
| this.ime.style.visibility = 'hidden'; | ||
| this.ime.dataset.hidden = 'true'; |
There was a problem hiding this comment.
Any chance we could just style [data-hidden='true'] { visibility: hidden; } rather than adding a direct write to the style property?
There was a problem hiding this comment.
Or even just this.ime.hidden = true; ? https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes?redirectlocale=en-US&redirectslug=HTML%2FGlobal_attributes#attr-hidden
There was a problem hiding this comment.
Agree, better not to write to the style property.
There was a problem hiding this comment.
this.ime.hidden = true would make it display: none. I changed it to using CSS.
Fix for #910697. Basically: