This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 959758 - [Messages] Long tapping any part horizontally adjacent to a message bubble brings up the message options menu #15326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| span = document.createElement('span'); | ||
|
|
||
| section.appendChild(span); |
There was a problem hiding this comment.
nit: maybe use a base <div> container and set its innerHTML, to make this easier to read?
There was a problem hiding this comment.
Sure I can do that
…o a message bubble brings up the message options menu r=julienw https://bugzilla.mozilla.org/show_bug.cgi?id=959758 Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
|
Merged 482a62a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=959758
There are currently jshint failures, but these were created by another patch and have a different bug to address them.
Signed-off-by: Rick Waldron waldron.rick@gmail.com