Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Bug 963013 - [Messages][Refresh] Update bubbles style and layout of the thread. #19437

Closed
wants to merge 1 commit into from
Closed

Bug 963013 - [Messages][Refresh] Update bubbles style and layout of the thread. #19437

wants to merge 1 commit into from

Conversation

nucliweb
Copy link
Contributor

No description provided.

@@ -33,6 +33,7 @@
height: auto;
overflow: hidden;
order: 2;
background-color: #fff;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're overriding the BB rule for form[role="search"]; should the BB rule be changed instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, I'd prefer to have background than background-color to reset all background properties

@julienw
Copy link
Contributor

julienw commented May 20, 2014

besides the comments, there is an issue: when there is the carrier subheader, the messages themselves should have a margin top or something, because currently the top of the message is under the sticky header.

To see this easily you can open a small thread for a contact

@mozilla-autolander-deprecated
Copy link
Contributor

This pull request has been closed due to tree stability issues. Please rebase and re-open the pull request if you still need to land this. Ensure the gaia-try run is green before landing. Sorry for any inconvenience.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants