This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 1034227 - [email] cookie cache DOM not localized on app restart #21364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
James Burke (jrburke)
jrburke
added a commit
that referenced
this pull request
Jul 4, 2014
Bug 1034227 - [email] cookie cache DOM not localized on app restart r=asuth,gandalf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In mail_app.js, if it knows a cachedNode will be used for startup, it passes it to mozL10n.translateFragment first. This fixes the root of the issue.
The change in tmpl.js for bug 1005760 is also removed because now the l10n.js MutationObservers translate the nodes on insertion, so it is just doing extra unneeded work to do this in tmpl.js. This can be confirmed by doing the following: