Bug 1047215 - [Gallery/Video]Background Overlays are not translated #22938
Conversation
|
|
russnicoletti
| nocard2-title = لم يتم العثور على بطاقة الذاكرة | ||
| nocard3-text = أدخل بطاقة الذاكرة لمشاهدة الفيديو. | ||
| nocard3-title = لم يتم العثور على بطاقة الذاكرة | ||
| nocard4-text = أدخل بطاقة الذاكرة لمشاهدة الفيديو. |
There was a problem hiding this comment.
Do we really need to rename the l10n key?
IIRC, we only do that when the meaning of sentence changed. I cannot make sure with this. If you have some information about this, please also email me. Thanks.
There was a problem hiding this comment.
I would suggest to rename as:
nocard4-title = ......
nocard4-text = .....
That makes more consistent.
russnicoletti
force-pushed
the
bug-1047215
branch
from
193bbbf
to
a5d3e5d
Compare
|
|
russnicoletti
force-pushed
the
bug-1047215
branch
from
a5d3e5d
to
0ec2811
Compare
|
|
russnicoletti
force-pushed
the
bug-1047215
branch
from
0ec2811
to
ffa9599
Compare
|
|
russnicoletti
force-pushed
the
bug-1047215
branch
from
ffa9599
to
cd51514
Compare
|
|
| @@ -737,36 +739,40 @@ function setPosterImage(dom, poster) { | |||
| } | |||
|
|
|||
| function showOverlay(id) { | |||
| currentOverlay = id; | |||
| LazyLoader.load('shared/style/confirm.css', function() { | |||
| console.log('showOverlay id=' + id); | |||
There was a problem hiding this comment.
We need to remove all console.log if they are useless.
russnicoletti
force-pushed
the
bug-1047215
branch
from
cd51514
to
e0b7b4b
Compare
|
|
russnicoletti
force-pushed
the
bug-1047215
branch
from
e0b7b4b
to
8a8dee2
Compare
|
|
russnicoletti
force-pushed
the
bug-1047215
branch
from
8a8dee2
to
7c20332
Compare
|
|
russnicoletti
force-pushed
the
bug-1047215
branch
from
7c20332
to
9e486fb
Compare
|
|
Bug 1047215 - [Gallery/Video]Background Overlays are not translated r=johu
This PR incorporates the patch from bug 1038984 as those changes to dialogs.js are required for this patch.