Bug 1055355 - Give content editable fields ARIA textbox roles. #23013
Conversation
|
|
Eitan Isaacson (eeejay)
| </div> | ||
| <div id="messages-input" contentEditable="true" name="message" x-inputmode="-moz-sms" class="js-l10n-placeholder"> | ||
| <div role="textbox" aria-multiline="true" id="messages-input" contentEditable="true" name="message" x-inputmode="-moz-sms" class="js-l10n-placeholder"> |
There was a problem hiding this comment.
does 'textbox' work fine when there are images inside the input (for MMS for example) ?
Wondering also why contentEditable fields are not visible by the screen reader?
There was a problem hiding this comment.
Having the 'textbox' role seems able to select and render the whole compose, but unfortunately it could not double-tap on the area to focus for editing when attachment inside the composer.
There was a problem hiding this comment.
nit: please remove the additional space before role
|
|
|
|
|
|
| @@ -24,6 +24,7 @@ | |||
| this.number = (opts.number || '') + ''; | |||
| this.email = opts.email || ''; | |||
| this.editable = opts.editable || 'true'; | |||
| this.role = this.editable ? 'textbox' : 'button'; | |||
There was a problem hiding this comment.
Could you please also update the unit test part? Because it would be helpful that preventing any possible regression in recipient node role.
eeejay
force-pushed
the
bug-1055355
branch
2 times, most recently
from
e722f5d
to
805640c
Compare
|
|
| word-wrap: unset; | ||
| background: none; | ||
| .recipient[contenteditable=true]:focus, | ||
| .recipient[contenteditable=true]:hover, |
There was a problem hiding this comment.
nit: I don't think we really need the hover pseudo class on device, or it's necessary for a11y?
There was a problem hiding this comment.
I'll check tomorrow morning, but I think that is important for overriding
building blocks.
On Thu, Sep 4, 2014 at 8:26 PM, steveck-chung notifications@github.com
wrote:
In apps/sms/style/sms.css:
- word-wrap: unset;
- background: none;
+.recipient[contenteditable=true]:focus,
+.recipient[contenteditable=true]:hover,nit: I don't think we really need the hover pseudo class on device, or
it's necessary for a11y?—
Reply to this email directly or view it on GitHub
https://github.com/mozilla-b2g/gaia/pull/23013/files#r17155618.
There was a problem hiding this comment.
Ah, indeed. It is there to be an override for the BB, I assume the hover style gets applied before/after :active? I don't know. In any case, I was playing it safe.
https://github.com/mozilla-b2g/gaia/blob/master/shared/style/input_areas.css#L461
|
|
Bug 1055355 - Give content editable fields ARIA textbox roles. r=steveck
No description provided.