1022767 use json l10n manifests #23549

+                                 self.official === '1' ?
+                                   'official' : 'unofficial',
+                                 utils.basename(resURL));
+        isBranding = true;


isBranding needs to be reset on the next iteration of the loop; otherwise it stays true for all subsequent files.

Actually, you could call this isOfficialBranding and avoid checking self.official again in line 171.

try-server-hook · 2014-09-02T21:04:49Z

Zibi Braniecki (zbraniecki) started tests. Results

try-server-hook · 2014-09-02T21:08:52Z

Zibi Braniecki (zbraniecki) started tests. Results

stasm · 2014-09-02T22:25:39Z

build/l10n.js

+          L10n.onManifestInjected.call(this, node.getAttribute('href'));
+          break;
+        case 'localization':
+          if (!('noFetch' in nodes[i].dataset)) {


Nit: use node in lieu of nodes[i] here.

try-server-hook · 2014-09-03T21:58:55Z

Zibi Braniecki (zbraniecki) started tests. Results

Pike · 2014-09-05T13:48:55Z

apps/collection/manifest.webapp

+    },
+    "zh-TW": {
+      "name": "Smart Collections",
+      "description": "Smart Collections Manager"


Collections are en-US only in the gaia repo, no additional locales.

try-server-hook · 2014-09-05T20:44:36Z

Zibi Braniecki (zbraniecki) started tests. Results

try-server-hook · 2014-09-05T21:17:42Z

Zibi Braniecki (zbraniecki) started tests. Results

try-server-hook · 2014-09-05T22:36:01Z

Zibi Braniecki (zbraniecki) started tests. Results

try-server-hook · 2014-09-10T23:44:57Z

Zibi Braniecki (zbraniecki) started tests. Results

try-server-hook · 2014-09-10T23:57:11Z

Zibi Braniecki (zbraniecki) started tests. Results

try-server-hook · 2014-09-11T00:12:38Z

Zibi Braniecki (zbraniecki) started tests. Results

try-server-hook · 2014-09-11T17:32:10Z

Zibi Braniecki (zbraniecki) started tests. Results

try-server-hook · 2014-09-12T00:15:47Z

Zibi Braniecki (zbraniecki) started tests. Results

try-server-hook · 2014-09-12T15:40:20Z

Zibi Braniecki (zbraniecki) started tests. Results

try-server-hook · 2014-09-15T21:13:00Z

Zibi Braniecki (zbraniecki) started tests. Results

try-server-hook · 2014-09-16T15:35:50Z

Zibi Braniecki (zbraniecki) started tests. Results

…adata. r=pike, yuren, stas

try-server-hook · 2014-09-16T15:46:33Z

Zibi Braniecki (zbraniecki) started tests. Results

…ests Bug 1022767 - Use manifest.webapp instead of locales.ini for l10n metadata. r=pike, yuren, stas

zbraniecki force-pushed the 1022767-use-json-l10n-manifests branch from 1952d6b to a6b3c7c Compare September 1, 2014 08:34

zbraniecki force-pushed the 1022767-use-json-l10n-manifests branch from a6b3c7c to 2a8aa0e Compare September 1, 2014 09:01

zbraniecki force-pushed the 1022767-use-json-l10n-manifests branch from 2a8aa0e to 1035a74 Compare September 1, 2014 19:52

zbraniecki force-pushed the 1022767-use-json-l10n-manifests branch from 1035a74 to 501eeae Compare September 1, 2014 20:02

zbraniecki force-pushed the 1022767-use-json-l10n-manifests branch from 501eeae to e226905 Compare September 1, 2014 20:22

zbraniecki force-pushed the 1022767-use-json-l10n-manifests branch from e226905 to 4574b2b Compare September 2, 2014 08:46

zbraniecki force-pushed the 1022767-use-json-l10n-manifests branch from 4574b2b to cb8bbb6 Compare September 2, 2014 09:37

stasm reviewed Sep 2, 2014
View reviewed changes

zbraniecki force-pushed the 1022767-use-json-l10n-manifests branch from cb8bbb6 to 3f7a9e8 Compare September 2, 2014 21:03

zbraniecki force-pushed the 1022767-use-json-l10n-manifests branch from 3f7a9e8 to bc48c57 Compare September 2, 2014 21:07

stasm reviewed Sep 2, 2014
View reviewed changes

zbraniecki force-pushed the 1022767-use-json-l10n-manifests branch from bc48c57 to 8bbf1ea Compare September 3, 2014 21:58

zbraniecki force-pushed the 1022767-use-json-l10n-manifests branch from 8bbf1ea to e440ff2 Compare September 4, 2014 00:15

Pike reviewed Sep 5, 2014
View reviewed changes

zbraniecki force-pushed the 1022767-use-json-l10n-manifests branch from 804f49d to 9f8d2eb Compare September 5, 2014 20:43

zbraniecki force-pushed the 1022767-use-json-l10n-manifests branch from 9f8d2eb to 893258b Compare September 5, 2014 21:16

zbraniecki force-pushed the 1022767-use-json-l10n-manifests branch from 893258b to c2aecca Compare September 5, 2014 22:35

zbraniecki force-pushed the 1022767-use-json-l10n-manifests branch from c2aecca to b69640b Compare September 10, 2014 23:44

zbraniecki force-pushed the 1022767-use-json-l10n-manifests branch from 73ae306 to edfd1e3 Compare September 11, 2014 00:11

zbraniecki force-pushed the 1022767-use-json-l10n-manifests branch from 25b39b5 to 54b1186 Compare September 12, 2014 00:14

zbraniecki force-pushed the 1022767-use-json-l10n-manifests branch from 54b1186 to 70a1444 Compare September 12, 2014 15:39

zbraniecki force-pushed the 1022767-use-json-l10n-manifests branch from 70a1444 to de5a5e7 Compare September 15, 2014 21:12

zbraniecki force-pushed the 1022767-use-json-l10n-manifests branch from de5a5e7 to 5015012 Compare September 16, 2014 15:35

Bug 1022767 - Use manifest.webapp instead of locales.ini for l10n met…

02ca679

…adata. r=pike, yuren, stas

zbraniecki force-pushed the 1022767-use-json-l10n-manifests branch from 5015012 to 02ca679 Compare September 16, 2014 15:45

zbraniecki added a commit that referenced this pull request Sep 16, 2014

Merge pull request #23549 from zbraniecki/1022767-use-json-l10n-manif…

b9c5dc6

…ests Bug 1022767 - Use manifest.webapp instead of locales.ini for l10n metadata. r=pike, yuren, stas

zbraniecki merged commit b9c5dc6 into mozilla-b2g:master Sep 16, 2014

zbraniecki deleted the 1022767-use-json-l10n-manifests branch October 6, 2014 20:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1022767 use json l10n manifests #23549

1022767 use json l10n manifests #23549

zbraniecki commented Sep 1, 2014

try-server-hook commented Sep 1, 2014

try-server-hook commented Sep 1, 2014

try-server-hook commented Sep 1, 2014

try-server-hook commented Sep 1, 2014

try-server-hook commented Sep 1, 2014

try-server-hook commented Sep 1, 2014

try-server-hook commented Sep 2, 2014

try-server-hook commented Sep 2, 2014

stasm Sep 2, 2014

stasm Sep 3, 2014

try-server-hook commented Sep 2, 2014

try-server-hook commented Sep 2, 2014

stasm Sep 2, 2014

try-server-hook commented Sep 3, 2014

Pike Sep 5, 2014

try-server-hook commented Sep 5, 2014

try-server-hook commented Sep 5, 2014

try-server-hook commented Sep 5, 2014

try-server-hook commented Sep 10, 2014

try-server-hook commented Sep 10, 2014

try-server-hook commented Sep 11, 2014

try-server-hook commented Sep 11, 2014

try-server-hook commented Sep 12, 2014

try-server-hook commented Sep 12, 2014

try-server-hook commented Sep 15, 2014

try-server-hook commented Sep 16, 2014

try-server-hook commented Sep 16, 2014

1022767 use json l10n manifests #23549

1022767 use json l10n manifests #23549

Conversation

zbraniecki commented Sep 1, 2014

try-server-hook commented Sep 1, 2014

try-server-hook commented Sep 1, 2014

try-server-hook commented Sep 1, 2014

try-server-hook commented Sep 1, 2014

try-server-hook commented Sep 1, 2014

try-server-hook commented Sep 1, 2014

try-server-hook commented Sep 2, 2014

try-server-hook commented Sep 2, 2014

stasm Sep 2, 2014

Choose a reason for hiding this comment

stasm Sep 3, 2014

Choose a reason for hiding this comment

try-server-hook commented Sep 2, 2014

try-server-hook commented Sep 2, 2014

stasm Sep 2, 2014

Choose a reason for hiding this comment

try-server-hook commented Sep 3, 2014

Pike Sep 5, 2014

Choose a reason for hiding this comment

try-server-hook commented Sep 5, 2014

try-server-hook commented Sep 5, 2014

try-server-hook commented Sep 5, 2014

try-server-hook commented Sep 10, 2014

try-server-hook commented Sep 10, 2014

try-server-hook commented Sep 11, 2014

try-server-hook commented Sep 11, 2014

try-server-hook commented Sep 12, 2014

try-server-hook commented Sep 12, 2014

try-server-hook commented Sep 15, 2014

try-server-hook commented Sep 16, 2014

try-server-hook commented Sep 16, 2014