This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 796305 - Sort tracks by number in albums. #23918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Hubert Figuière (hfiguiere)
|
As it is now, it pulls work done PR #11500 that is required for this. |
hfiguiere
force-pushed
the
bug796305-album-sort
branch
from
8a991d3
to
3213d3d
Compare
|
|
hfiguiere
force-pushed
the
bug796305-album-sort
branch
from
3213d3d
to
58358a3
Compare
|
|
…elds. An ID3 tag is *all* the metadata; a frame is a single field.
TODO: * Need a better UI while we're actually updating (e.g. show a spinner and don't let the user touch stuff)
Conflicts: apps/music/test/unit/id3_test.js
…e cache for thumbnails
Modify id3v2.3, ogg and mp4 test file to include that metadata.
hfiguiere
force-pushed
the
bug796305-album-sort
branch
from
58358a3
to
ae18fb7
Compare
|
|
|
This pull request has been closed due to tree stability issues. Please rebase and re-open the pull request if you still need to land this. Ensure the gaia-try run is green before landing. Sorry for any inconvenience. |
|
|
|
Squashed in #23961 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.