Track sorting and listing improvements. (Bug 796305 and bug 841977) #23961

hfiguiere · 2014-09-11T17:15:14Z

Includes dependencies that have to land before this. ie will be rebased when time comes.

try-server-hook · 2014-09-11T17:16:03Z

Hubert Figuière (hfiguiere) started tests. Results

try-server-hook · 2014-09-11T17:20:12Z

Hubert Figuière (hfiguiere) started tests. Results

try-server-hook · 2014-09-14T03:32:22Z

Hubert Figuière (hfiguiere) started tests. Results

try-server-hook · 2014-09-16T11:56:40Z

Hubert Figuière (hfiguiere) started tests. Results

try-server-hook · 2014-09-24T15:11:51Z

Hubert Figuière (hfiguiere) started tests. Results

jimporter · 2014-09-24T18:07:14Z

apps/music/js/music.js

@@ -1147,7 +1180,12 @@ function createListElement(option, data, index, highlight) {

      var indexSpan = document.createElement('span');
      indexSpan.className = 'list-song-index';
-      indexSpan.textContent = index + 1;
+      var trackNum = data.metadata.tracknum;
+      if (data.multidisc) {


We should probably be extra-careful here and only show the disc number if data.metadata.discnum exists. Otherwise, we'll get something weird like undefined.01 for the index.

good point. I'll update to

if (data.metadata.discnum && data.multidisc)

try-server-hook · 2014-09-24T20:28:18Z

Hubert Figuière (hfiguiere) started tests. Results

try-server-hook · 2014-09-25T02:55:36Z

Hubert Figuière (hfiguiere) started tests. Results

try-server-hook · 2014-09-27T02:44:40Z

Hubert Figuière (hfiguiere) started tests. Results

try-server-hook · 2014-09-27T22:48:20Z

Hubert Figuière (hfiguiere) started tests. Results

try-server-hook · 2014-10-01T17:37:02Z

Hubert Figuière (hfiguiere) started tests. Results

try-server-hook · 2014-10-01T17:49:47Z

Hubert Figuière (hfiguiere) started tests. Results

mozilla-autolander-deprecated · 2014-10-01T21:49:26Z

This pull request has been closed due to tree stability issues. Please rebase and re-open the pull request if you still need to land this. Ensure the gaia-try run is green before landing. Sorry for any inconvenience.

try-server-hook · 2014-10-02T13:07:12Z

Hubert Figuière (hfiguiere) started tests. Results

try-server-hook · 2014-10-02T19:12:10Z

Hubert Figuière (hfiguiere) started tests. Results

try-server-hook · 2014-10-08T18:29:12Z

Hubert Figuière (hfiguiere) started tests. Results

try-server-hook · 2014-10-09T03:06:35Z

Hubert Figuière (hfiguiere) started tests. Results

try-server-hook · 2014-10-15T23:37:55Z

Hubert Figuière (hfiguiere) started tests. Results

jimporter · 2014-10-16T23:08:05Z

apps/music/js/music.js

+
+        maxDiscNum = Math.max(
+          dataArray[dataArray.length - 1].metadata.disccount,
+          dataArray[dataArray.length - 1].metadata.discnum


Note that it's possible (but unlikely) that this won't get you the maximum disccount value, since you're sorting by discnum and not disccount.

…mber if relevant.

try-server-hook · 2014-10-17T14:37:12Z

Hubert Figuière (hfiguiere) started tests. Results

hfiguiere · 2014-10-17T17:04:50Z

Gij failiure is https://bugzilla.mozilla.org/show_bug.cgi?id=1084453

Track sorting and listing improvements. (Bug 796305 and bug 841977) r=squib

hfiguiere force-pushed the disc-numbers-list branch from b96da07 to a72dc3b Compare September 11, 2014 17:19

hfiguiere force-pushed the disc-numbers-list branch from a72dc3b to 294d9df Compare September 14, 2014 03:31

hfiguiere force-pushed the disc-numbers-list branch from 294d9df to a25f278 Compare September 16, 2014 11:55

hfiguiere force-pushed the disc-numbers-list branch 2 times, most recently from e458adf to 97b0ec1 Compare September 24, 2014 15:10

jimporter reviewed Sep 24, 2014
View reviewed changes

hfiguiere force-pushed the disc-numbers-list branch from 97b0ec1 to 6d9f90c Compare September 24, 2014 20:27

hfiguiere force-pushed the disc-numbers-list branch from 6d9f90c to c6df514 Compare September 25, 2014 02:54

hfiguiere force-pushed the disc-numbers-list branch from f09a4e5 to 84c8f20 Compare September 27, 2014 22:47

hfiguiere force-pushed the disc-numbers-list branch from 0d6182e to 34ab35d Compare October 1, 2014 17:47

mozilla-autolander-deprecated closed this Oct 1, 2014

hfiguiere reopened this Oct 2, 2014

hfiguiere force-pushed the disc-numbers-list branch from 34ab35d to c9b4392 Compare October 2, 2014 19:11

hfiguiere force-pushed the disc-numbers-list branch from c9b4392 to b7fcf89 Compare October 8, 2014 18:28

hfiguiere force-pushed the disc-numbers-list branch from b7fcf89 to 95cd0b0 Compare October 9, 2014 03:05

hfiguiere force-pushed the disc-numbers-list branch from 95cd0b0 to 4a65d29 Compare October 15, 2014 23:37

hfiguiere changed the title ~~Bug 841977 - Show track number instead of index. Also disc number if relevant.~~ Track sorting and listing improvements. (Bug 796305 and bug 841977) Oct 15, 2014

jimporter reviewed Oct 16, 2014
View reviewed changes

hfiguiere added 4 commits October 17, 2014 10:31

Bug 796305 - Part 2: sort album sublist by track number.

7dca003

Bug 841977 - Part 2: Show track number instead of index. Also disc nu…

9f235c5

…mber if relevant.

Bug 841977 - Part 3: added marionette tests

8340525

Bug 796305 - Part 3: Marionette test for single disc

8b18597

hfiguiere force-pushed the disc-numbers-list branch from 4a65d29 to 8b18597 Compare October 17, 2014 14:36

hfiguiere added a commit that referenced this pull request Oct 17, 2014

Merge pull request #23961 from hfiguiere/disc-numbers-list

79333a3

Track sorting and listing improvements. (Bug 796305 and bug 841977) r=squib

hfiguiere merged commit 79333a3 into mozilla-b2g:master Oct 17, 2014

hfiguiere mentioned this pull request Oct 17, 2014

Bug 796305 - Sort tracks by number in albums. #23918

Closed

hfiguiere deleted the disc-numbers-list branch October 17, 2014 17:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Track sorting and listing improvements. (Bug 796305 and bug 841977) #23961

Track sorting and listing improvements. (Bug 796305 and bug 841977) #23961

hfiguiere commented Sep 11, 2014

try-server-hook commented Sep 11, 2014

try-server-hook commented Sep 11, 2014

try-server-hook commented Sep 14, 2014

try-server-hook commented Sep 16, 2014

try-server-hook commented Sep 24, 2014

jimporter Sep 24, 2014

hfiguiere Sep 24, 2014

try-server-hook commented Sep 24, 2014

try-server-hook commented Sep 25, 2014

try-server-hook commented Sep 27, 2014

try-server-hook commented Sep 27, 2014

try-server-hook commented Oct 1, 2014

try-server-hook commented Oct 1, 2014

mozilla-autolander-deprecated commented Oct 1, 2014

try-server-hook commented Oct 2, 2014

try-server-hook commented Oct 2, 2014

try-server-hook commented Oct 8, 2014

try-server-hook commented Oct 9, 2014

try-server-hook commented Oct 15, 2014

jimporter Oct 16, 2014

try-server-hook commented Oct 17, 2014

hfiguiere commented Oct 17, 2014

Track sorting and listing improvements. (Bug 796305 and bug 841977) #23961

Track sorting and listing improvements. (Bug 796305 and bug 841977) #23961

Conversation

hfiguiere commented Sep 11, 2014

try-server-hook commented Sep 11, 2014

try-server-hook commented Sep 11, 2014

try-server-hook commented Sep 14, 2014

try-server-hook commented Sep 16, 2014

try-server-hook commented Sep 24, 2014

jimporter Sep 24, 2014

Choose a reason for hiding this comment

hfiguiere Sep 24, 2014

Choose a reason for hiding this comment

try-server-hook commented Sep 24, 2014

try-server-hook commented Sep 25, 2014

try-server-hook commented Sep 27, 2014

try-server-hook commented Sep 27, 2014

try-server-hook commented Oct 1, 2014

try-server-hook commented Oct 1, 2014

mozilla-autolander-deprecated commented Oct 1, 2014

try-server-hook commented Oct 2, 2014

try-server-hook commented Oct 2, 2014

try-server-hook commented Oct 8, 2014

try-server-hook commented Oct 9, 2014

try-server-hook commented Oct 15, 2014

jimporter Oct 16, 2014

Choose a reason for hiding this comment

try-server-hook commented Oct 17, 2014

hfiguiere commented Oct 17, 2014