This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 1075757 - call_log_test depends on the mozContacts API #24842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Anthony Ricaud (Rik)
| realMozContacts = navigator.mozContacts; | ||
| navigator.mozContacts = MockMozContacts; | ||
|
|
||
| navigator.mozContacts.oncontactchange = realMozContacts.oncontactchange; |
There was a problem hiding this comment.
I don't see how this would fix the issue when mozContacts is unavailable.
rik
force-pushed
the
mock-moz-contacts-1075757
branch
from
3145471
to
f993b5b
Compare
|
|
| @@ -3,9 +3,8 @@ | |||
| /* global CallHandler, CallLog, CallLogDBManager, Contacts, KeypadManager, | |||
| MockMozL10n, MockNavigatorMozIccManager, MockNotification, | |||
| MocksHelper, MockSimSettingsHelper, Notification, | |||
There was a problem hiding this comment.
Could you switch us to just using MockNotification while you're here?
rik
force-pushed
the
mock-moz-contacts-1075757
branch
from
f993b5b
to
8825f66
Compare
|
|
rik
added a commit
that referenced
this pull request
Oct 8, 2014
Bug 1075757 - call_log_test depends on the mozContacts API r=drs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.