This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Makefile's Win32 support #2666
Merged
Makefile's Win32 support #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@vingtetun I can only drink @etiennesegonzac's maté if this pull request lands :p |
| @@ -1 +1 @@ | |||
| @GAIA_DIR@/profile/extensions/httpd/ | |||
| httpd | |||
There was a problem hiding this comment.
This is the only things that worry me. I thought the path should be absolute?
There was a problem hiding this comment.
I thought exactly the same thing, but I gave it a try and it works :p
You can try it on linux/mac, it would most likely works too.
There was a problem hiding this comment.
That's weird. Maybe the platform has changed at some point. Let's land that and try it. @etiennesegonzac You're good to buy some Maté!
|
\o/ maté! |
|
@ochameau please attach a picture of your tasty beverage to this PR for history :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I split this in multiple meaningfull commits. I didn't knew about gaia policy in term of rebase and landing ...
Otherwise the biggest change here is webapps folders.
I had to change webapps folder name, as they contained
:which is forbidden in Windows file names.