Bug 1118946 - Use new App.name API for gaia grid l10n #28510

zbraniecki · 2015-02-26T21:44:15Z

https://bugzilla.mozilla.org/show_bug.cgi?id=1118946

try-server-hook · 2015-03-04T22:36:29Z

Zibi Braniecki (zbraniecki) started tests. Results

try-server-hook · 2015-03-04T22:51:00Z

Zibi Braniecki (zbraniecki) started tests. Results

KevinGrandon · 2015-03-04T22:56:30Z

shared/elements/gaia_grid/js/items/mozapp.js

+      return this.app.getLocalizedValue('short_name', userLang, ep).then(
+        n => n,
+        this.app.getLocalizedValue.bind(this.app, 'name', userLang, ep)).then(
+          function(name) {


Let's not mix styles, just use an arrow function here, .then(name => {

try-server-hook · 2015-03-05T06:02:44Z

Zibi Braniecki (zbraniecki) started tests. Results

try-server-hook · 2015-03-06T02:48:50Z

Zibi Braniecki (zbraniecki) started tests. Results

try-server-hook · 2015-03-06T22:00:16Z

Zibi Braniecki (zbraniecki) started tests. Results

try-server-hook · 2015-03-07T04:08:23Z

Zibi Braniecki (zbraniecki) started tests. Results

try-server-hook · 2015-03-07T04:37:02Z

Zibi Braniecki (zbraniecki) started tests. Results

try-server-hook · 2015-03-07T07:02:36Z

Zibi Braniecki (zbraniecki) started tests. Results

try-server-hook · 2015-03-09T19:22:22Z

Zibi Braniecki (zbraniecki) started tests. Results

try-server-hook · 2015-03-09T20:20:59Z

Zibi Braniecki (zbraniecki) started tests. Results

try-server-hook · 2015-03-10T23:56:03Z

Kevin Grandon (KevinGrandon) started tests. Results

stasm · 2015-03-11T11:14:01Z

shared/elements/gaia_grid/js/items/mozapp.js

+      var ep = this.entryPoint || undefined;
+
+      return this.app.getLocalizedValue('short_name', userLang, ep).then(
+        n => n,


Can we also apply the pseudolocale logic here in case we get back the English value of short_name?

try-server-hook · 2015-03-11T18:55:06Z

Zibi Braniecki (zbraniecki) started tests. Results

KevinGrandon · 2015-03-11T20:35:02Z

shared/elements/gaia_grid/js/items/grid_item.js

@@ -529,7 +529,15 @@

        var nameEl = document.createElement('span');
        nameEl.className = 'title';
-        nameEl.textContent = this.name;
+
+        if (this.asyncName) {


Can this call this.updateTitle after assigning the element to this.element?

Bug 1118946 - Use new App.name API for gaia grid l10n. r=kgrandon

zbraniecki force-pushed the 1118946-app-names-from-api branch from ac26ddb to b2350de Compare March 4, 2015 22:34

zbraniecki force-pushed the 1118946-app-names-from-api branch from b2350de to 5550f5d Compare March 4, 2015 22:50

KevinGrandon reviewed Mar 4, 2015
View reviewed changes

zbraniecki force-pushed the 1118946-app-names-from-api branch from 5550f5d to 4ac3cf6 Compare March 5, 2015 06:01

zbraniecki force-pushed the 1118946-app-names-from-api branch from 4ac3cf6 to 92e5e39 Compare March 6, 2015 02:47

zbraniecki force-pushed the 1118946-app-names-from-api branch from 92e5e39 to 20b9fca Compare March 6, 2015 21:59

zbraniecki force-pushed the 1118946-app-names-from-api branch from 20b9fca to d95e738 Compare March 7, 2015 04:07

zbraniecki force-pushed the 1118946-app-names-from-api branch from d95e738 to 1b4d2d2 Compare March 7, 2015 04:36

zbraniecki force-pushed the 1118946-app-names-from-api branch from 1b4d2d2 to 1a89463 Compare March 7, 2015 07:01

zbraniecki force-pushed the 1118946-app-names-from-api branch from 1a89463 to 9dd5727 Compare March 9, 2015 19:21

zbraniecki force-pushed the 1118946-app-names-from-api branch from 9dd5727 to 1dfcddf Compare March 9, 2015 20:20

KevinGrandon closed this Mar 10, 2015

KevinGrandon reopened this Mar 10, 2015

stasm reviewed Mar 11, 2015
View reviewed changes

zbraniecki force-pushed the 1118946-app-names-from-api branch from 1dfcddf to 9537451 Compare March 11, 2015 18:54

KevinGrandon reviewed Mar 11, 2015
View reviewed changes

Bug 1118946 - Use new App.name API for gaia grid l10n

c70a699

zbraniecki force-pushed the 1118946-app-names-from-api branch from 9537451 to c70a699 Compare March 11, 2015 20:55

zbraniecki added a commit that referenced this pull request Mar 11, 2015

Merge pull request #28510 from zbraniecki/1118946-app-names-from-api

e125989

Bug 1118946 - Use new App.name API for gaia grid l10n. r=kgrandon

zbraniecki merged commit e125989 into mozilla-b2g:master Mar 11, 2015

zbraniecki deleted the 1118946-app-names-from-api branch May 8, 2015 18:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1118946 - Use new App.name API for gaia grid l10n #28510

Bug 1118946 - Use new App.name API for gaia grid l10n #28510

zbraniecki commented Feb 26, 2015

try-server-hook commented Mar 4, 2015

try-server-hook commented Mar 4, 2015

KevinGrandon Mar 4, 2015

try-server-hook commented Mar 5, 2015

try-server-hook commented Mar 6, 2015

try-server-hook commented Mar 6, 2015

try-server-hook commented Mar 7, 2015

try-server-hook commented Mar 7, 2015

try-server-hook commented Mar 7, 2015

try-server-hook commented Mar 9, 2015

try-server-hook commented Mar 9, 2015

try-server-hook commented Mar 10, 2015

stasm Mar 11, 2015

try-server-hook commented Mar 11, 2015

KevinGrandon Mar 11, 2015

Bug 1118946 - Use new App.name API for gaia grid l10n #28510

Bug 1118946 - Use new App.name API for gaia grid l10n #28510

Conversation

zbraniecki commented Feb 26, 2015

try-server-hook commented Mar 4, 2015

try-server-hook commented Mar 4, 2015

KevinGrandon Mar 4, 2015

Choose a reason for hiding this comment

try-server-hook commented Mar 5, 2015

try-server-hook commented Mar 6, 2015

try-server-hook commented Mar 6, 2015

try-server-hook commented Mar 7, 2015

try-server-hook commented Mar 7, 2015

try-server-hook commented Mar 7, 2015

try-server-hook commented Mar 9, 2015

try-server-hook commented Mar 9, 2015

try-server-hook commented Mar 10, 2015

stasm Mar 11, 2015

Choose a reason for hiding this comment

try-server-hook commented Mar 11, 2015

KevinGrandon Mar 11, 2015

Choose a reason for hiding this comment