This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Cancel the installation when user hold home button #29471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanxd
force-pushed
the
bug-1148733
branch
3 times, most recently
from
ef648aa
to
dac776d
Compare
|
Autolander could not find a bug number in your pull request title. All pull requests should be in the format of: Bug [number] - [description]. |
| assert.equal('visible', AppInstallManager.dialog.className); | ||
| AppInstallManager.handleHomeButtonPressed(evt); | ||
| AppInstallManager.cancelInstallation(); |
There was a problem hiding this comment.
With this approach we're not covering with tests that the event listeners are properly set.
Instead of calling cancelInstallation() directly you can dispatch real event ie.
window.dispatchEvent(new CustomEvent('holdhome'));
This will make the test more external and test more code for the same amount of test lines :)
There was a problem hiding this comment.
maybe a home event here
|
Autolander could not find a bug number in your pull request title. All pull requests should be in the format of: Bug [number] - [description]. |
evanxd
added a commit
that referenced
this pull request
Apr 14, 2015
Cancel the installation when user hold home button
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.