-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Bug 1164869 - Flame: Create imagecompare test which downloads map app #30225
Conversation
Couldn't think of better way to wait for the app to finish drawing the map other than giving enough time to sleep. |
time.sleep(self.wait_until_draw_done) | ||
self.take_screenshot() | ||
|
||
#once the map is completely loaded, use the UI to render different views |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, space
No, I wouldn't know of any way of detecting when the map has finished drawing, either. So I guess the timer is the only thing you can do here. |
results = marketplace.search(self.app_search) | ||
first_result = results.search_results[0] | ||
app_name = first_result.get_app_name() | ||
first_result.tap_install_button() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no way to install the app without using Marketplace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think bing maps is available only through Marketplace. I did think about looking for app pkg, then the app might get stale, and with the talk about getting rid of pkged apps in v3, thought downloading via marketplace would be more sustainable.
… mozilla-b2g:master
http://docs.taskcluster.net/tools/task-graph-inspector/#K6ZyKDNtSmSc_KKbw8e9GA The pull request failed to pass integration tests. It could not be landed, please try again. |
The test log itself shows not failures, and from the treeherder link, it says the tests that taskcluster is reporting is passed. Since the patch involves addition python marionette on device test and nothing else, even if there is a real failure, this patch should not be the cause of it. Manually merging. |
Bug 1164869 - Flame: Create imagecompare test which downloads map app
No description provided.