Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Bug 1164869 - Flame: Create imagecompare test which downloads map app #30225

Merged
merged 1 commit into from
May 26, 2015
Merged

Bug 1164869 - Flame: Create imagecompare test which downloads map app #30225

merged 1 commit into from
May 26, 2015

Conversation

nojunpark
Copy link

No description provided.

@lightsofapollo
Copy link
Contributor

@nojunpark
Copy link
Author

Couldn't think of better way to wait for the app to finish drawing the map other than giving enough time to sleep.

time.sleep(self.wait_until_draw_done)
self.take_screenshot()

#once the map is completely loaded, use the UI to render different views
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, space

@mwargers
Copy link
Contributor

No, I wouldn't know of any way of detecting when the map has finished drawing, either. So I guess the timer is the only thing you can do here.

@lightsofapollo
Copy link
Contributor

results = marketplace.search(self.app_search)
first_result = results.search_results[0]
app_name = first_result.get_app_name()
first_result.tap_install_button()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no way to install the app without using Marketplace?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think bing maps is available only through Marketplace. I did think about looking for app pkg, then the app might get stale, and with the talk about getting rid of pkged apps in v3, thought downloading via marketplace would be more sustainable.

@lightsofapollo
Copy link
Contributor

@mozilla-autolander-deprecated
Copy link
Contributor

http://docs.taskcluster.net/tools/task-graph-inspector/#K6ZyKDNtSmSc_KKbw8e9GA

The pull request failed to pass integration tests. It could not be landed, please try again.

@nojunpark
Copy link
Author

The test log itself shows not failures, and from the treeherder link, it says the tests that taskcluster is reporting is passed. Since the patch involves addition python marionette on device test and nothing else, even if there is a real failure, this patch should not be the cause of it. Manually merging.

nojunpark pushed a commit that referenced this pull request May 26, 2015
 Bug 1164869 - Flame: Create imagecompare test which downloads map app
@nojunpark nojunpark merged commit b168b4e into mozilla-b2g:master May 26, 2015
@nojunpark nojunpark deleted the 1164869 branch May 27, 2015 19:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants