This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 1196178 - Always show change APN warning when data roaming is no or off #31575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -92,8 +92,7 @@ define(function(require) { | |||
| }) | |||
| ]).then(function(results) { | |||
| var activeApnId = results[0]; | |||
| var dataRoamingEnabled = results[1]; | |||
| if (activeApnId === _apnItem.id && dataRoamingEnabled) { | |||
| if (activeApnId === _apnItem.id) { | |||
There was a problem hiding this comment.
we can remove above Promise.all and new Promise((resolve) => {} and use new Promise instead since the dataRoamingEnabled is not used.
The comment
// Display the warning only when Data roaming is turned on and it is
// the current APN in use that’s being edited.
should be updated as well
… want to proceed r=gasolin, evelyn
evanxd
added a commit
that referenced
this pull request
Sep 16, 2015
Bug 1196178 - Always show change APN warning when data roaming is no or off r=evelyn, gasolin
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.