Bug 1196717 - Dogfood test - Delete thread in SMS #31611
Conversation
| Wait(self.marionette).until(expected.element_not_displayed(el)) | ||
| back_button = self.marionette.find_element(*self._details_header_locator) | ||
| self.tap_element_from_system_app(element=back_button) | ||
| Wait(self.marionette).until(expected.element_not_displayed(back_button)) |
There was a problem hiding this comment.
tap_element_from_system_app is switching to the system app, so I'm not sure how this works.
In general, I would prefer it we're going away from negative checks like these.
But I guess it works, because otherwise you haven't written it like this.
There was a problem hiding this comment.
Wait a minute, is this tap_element_from_system_app method really necessary here?
I mean, we're not closing an app here, do we? We just stay in the contacts app, or not?
There was a problem hiding this comment.
We need to tap the close button, which is in an HTML custom element. So Marionette doesn't see the button
There was a problem hiding this comment.
Yes, but I mean the tap_element_from_system_app call you're making here. Is that really necessary? Because this should only be used when it is really necessary.
There was a problem hiding this comment.
Isn't that the way we tap on Shadow DOM elements?
There was a problem hiding this comment.
No, it's used when the button that's being tapped upon closes the app. When that happens, Marionette is out of whack, because it still thinks the active frame that is being worked on is that app. See https://bugzilla.mozilla.org/show_bug.cgi?id=1164078 for more explanation.
For shadow DOM elements, you just have to use coordinates.
There was a problem hiding this comment.
Okay. I'll change it
There was a problem hiding this comment.
I rolled back these changes.
|
|
||
| [test_delete_thread.py] | ||
| skip-if = device == "desktop" | ||
| dogfood = true |
There was a problem hiding this comment.
If you keep on using Plivo, then I guess you need to add external = true here.
There was a problem hiding this comment.
You're right. I added it.
Bug 1196717 - Dogfood test - Delete thread in SMS
No description provided.