This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 1211395 - Performance regression in Message #32458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!this.selectionHandler) { | ||
| LazyLoader.load('/views/shared/js/selection_handler.js', () => { | ||
| LazyLoader.load([ |
There was a problem hiding this comment.
Looks like this part could be wrapped into utils. BTW it's amazing that we have 3 different edit-mode.css for an edit form...
steveck-chung
force-pushed
the
message-performance-improve
branch
from
79c96b0
to
6a1ba3e
Compare
| _lazyLoadInit: function() { | ||
| var lazyLoadPromise = LazyLoader.load(this._lazyLoadScripts).then(() => { | ||
| var lazyLoadFiles = this._lazyLoadScripts.concat(this._lazyLoadStyles); | ||
| var lazyLoadPromise = LazyLoader.load(lazyLoadFiles).then(() => { |
There was a problem hiding this comment.
optional nit: you probably can do load([...this._lazyLoadScripts, ...this._lazyLoadStyles])
steveck-chung
force-pushed
the
message-performance-improve
branch
from
6a1ba3e
to
f7d5bdf
Compare
steveck-chung
force-pushed
the
message-performance-improve
branch
from
f7d5bdf
to
ec87030
Compare
| @@ -611,6 +613,18 @@ suite('navigation >', function() { | |||
| }).then(done, done); | |||
| }); | |||
| }); | |||
|
|
|||
| suite('setReady', function() { | |||
There was a problem hiding this comment.
This trick is only for non-split view, so only add it in the non-split test suite.
|
this needs a simple rebase |
steveck-chung
force-pushed
the
message-performance-improve
branch
from
ec87030
to
409c04a
Compare
|
Rebased! |
| @@ -6681,7 +6683,10 @@ suite('conversation.js >', function() { | |||
|
|
|||
| test('enables the font-fit algorithm in headers', function() { | |||
| assert.isFalse(header.hasAttribute('no-font-fit')); | |||
| assert.isFalse(editHeader.hasAttribute('no-font-fit')); | |||
There was a problem hiding this comment.
mmm this test should move in the edit mode tests, I think ?
There was a problem hiding this comment.
ok I see it's in sms_test...
steveck-chung
force-pushed
the
message-performance-improve
branch
from
428a8f6
to
f1c8369
Compare
steveck-chung
added a commit
that referenced
this pull request
Oct 23, 2015
Bug 1211395 - Performance regression in Message, r=julienw azasypkin
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.