This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 1207468 - Prefix asyncStorage entries with userid in DataAdapters, r=ferjm #32596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michielbdejong
force-pushed
the
1207468-fxsyncid-datastoreid-mapping
branch
from
5bc4731
to
a9ec474
Compare
michielbdejong
force-pushed
the
1207468-fxsyncid-datastoreid-mapping
branch
from
a9ec474
to
5cfda9f
Compare
michielbdejong
force-pushed
the
1207468-fxsyncid-datastoreid-mapping
branch
from
5cfda9f
to
a67ac55
Compare
michielbdejong
changed the title
michielbdejong
changed the title
|
There's a test failing |
michielbdejong
force-pushed
the
1207468-fxsyncid-datastoreid-mapping
branch
from
a67ac55
to
e891287
Compare
| promises.push(this._updateCollection(collectionName, | ||
| //TODO: actually use this, see bug 1209934 |
There was a problem hiding this comment.
That bug is fixed now.
|
@ferjm TreeHerder problem? ^ Is there a way to retrigger the run? |
|
The latest test run seems to have failed because of https://bugzilla.mozilla.org/show_bug.cgi?id=1197788. |
michielbdejong
force-pushed
the
1207468-fxsyncid-datastoreid-mapping
branch
from
e891287
to
f527880
Compare
|
Rebased. |
michielbdejong
force-pushed
the
1207468-fxsyncid-datastoreid-mapping
branch
from
f527880
to
af005eb
Compare
michielbdejong
force-pushed
the
1207468-fxsyncid-datastoreid-mapping
branch
from
af005eb
to
4d04937
Compare
|
Updated a test in history_test.js that was new in master today. |
| @@ -65,16 +65,18 @@ var BookmarksHelper = (() => { | |||
| Due to this common requirement, bug 1207468 will have an improvement for | |||
| this case. | |||
| */ | |||
| function setDataStoreId(synctoId, dataStoreId) { | |||
| function setDataStoreId(synctoId, dataStoreId, userid) { | |||
There was a problem hiding this comment.
Update the comments to explain why we need to add the userid prefix, please.
There was a problem hiding this comment.
Actually, improving comments in general on adapters code would be really helpful.
There was a problem hiding this comment.
Created https://bugzilla.mozilla.org/show_bug.cgi?id=1218278 as a follow-up.
michielbdejong
force-pushed
the
1207468-fxsyncid-datastoreid-mapping
branch
from
4d04937
to
f6f12ac
Compare
michielbdejong
force-pushed
the
1207468-fxsyncid-datastoreid-mapping
branch
from
f6f12ac
to
234827f
Compare
ferjm
added a commit
that referenced
this pull request
Oct 26, 2015
…oreid-mapping Bug 1207468 - Prefix asyncStorage entries with userid in DataAdapters, r=ferjm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.