This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 1180236 - Timing adjustments R=mhenretty #34005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| test('open new window', function() { | ||
| // Use the home-screen search box to open up the system browser | ||
| var url = server.url('sample.html'); | ||
| rocketbar.homescreenFocus(); | ||
| rocketbar.enterText(url, true); | ||
|
|
||
| // Count the number of currently open apps | ||
| // Wait for all app windows to show up | ||
| client.helper.wait(1000); |
There was a problem hiding this comment.
This kinda thing always makes me nervous. We need to wait on specific things happening, not an arbitrary amount of time. Is there nothing specifically we can check for in the DOM?
| test('open new window', function() { | ||
| // Use the home-screen search box to open up the system browser | ||
| var url = server.url('sample.html'); | ||
| rocketbar.homescreenFocus(); | ||
| rocketbar.enterText(url, true); | ||
| system.waitForBrowser(url); |
There was a problem hiding this comment.
Better than just waiting for 1000ms.
tilmankamp
added a commit
that referenced
this pull request
Feb 4, 2016
Bug 1180236 - Timing adjustments R=mhenretty
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both tests in browser_chrome_new_window_test.js were intermittent. The 'open new window and edge swipe' one relies on a certain event order and timing. Test node performance differences could (still) result in different event orders. However: This change tries to lower that probability as much as possible.