Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Facebook. Adding Wall Post and Send Message using FB Dialogs #5315

Merged

Conversation

jmcanterafonseca
Copy link
Contributor

Disclaimers: It does not include the latest iconography. That will be part of a different PR.

@albertopq, @arcturus R?

@jmcanterafonseca
Copy link
Contributor Author

/botio lint

@ghost
Copy link

ghost commented Sep 27, 2012

From: Bot.io (Main)


Received

Command cmd_lint from @jmcanterafonseca received. Current queue size: 0

Live output at: http://50.116.11.35:8000/208567a36dc8244/output.txt

@ghost
Copy link

ghost commented Sep 27, 2012

From: Bot.io (Main)


Failed

Full output at http://50.116.11.35:8000/208567a36dc8244/output.txt

Total script time: 6.64 mins

Lint: FAILED
----Skipping 55 file(s).
----- /apps/calculator/js/calculator.js
55, E:0002: Missing space before "("
56, E:0002: Missing space before "("
58, E:0002: Missing space before "("
67, E:0002: Missing space before "("
69, E:0002: Missing space before "("
----- /apps/communications/contacts/js/contacts_details.js
266, E:0002: Missing space before "("
----- /apps/email/js/mail-app.js
30, E:0121: Illegal comma at end of object literal
----- /apps/homescreen/js/bookmark.js
23, E:0010: Missing semicolon at end of line
----- /apps/system/js/statusbar.js
98, E:0001: Extra space at end of line
128, E:0001: Extra space at end of line
----- /apps/system/js/window_manager.js
765, E:0110: Line too long (81 characters).
820, E:0110: Line too long (81 characters).
822, E:0110: Line too long (85 characters).
1199, E:0002: Missing space before "("
----- /apps/system/js/wrapper.js
34, E:0002: Missing space before "("
42, E:0002: Missing space before "("
----- /apps/system/test/unit/date_picker_test.js
94, E:0110: Line too long (81 characters).
Found 17 errors, including 1 new errors, in 8 files (334 files OK).

Some of the errors reported by GJsLint may be auto-fixable using the script
fixjsstyle. Please double check any changes it makes and report any bugs. The
script can be run by executing:

fixjsstyle --nojsdoc -r apps -e sms/js/ext,pdfjs/content,pdfjs/test,email/js/ext,music/js/ext,calendar/js/ext
make: *** [lint] Error 3

@jmcanterafonseca
Copy link
Contributor Author

/botio lint

@ghost
Copy link

ghost commented Sep 28, 2012

From: Bot.io (Main)


Received

Command cmd_lint from @jmcanterafonseca received. Current queue size: 0

Live output at: http://50.116.11.35:8000/60bd60f9d1159bf/output.txt

@ghost
Copy link

ghost commented Sep 28, 2012

From: Bot.io (Main)


Success

Full output at http://50.116.11.35:8000/60bd60f9d1159bf/output.txt

Total script time: 1.59 mins

jmcanterafonseca added a commit that referenced this pull request Sep 30, 2012
Facebook. Adding Wall Post and Send Message using FB Dialogs
@jmcanterafonseca jmcanterafonseca merged commit 85e724c into mozilla-b2g:master Sep 30, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant