This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 796432 - Avoiding remove a phone when clicking RETURN key #5942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -586,7 +586,7 @@ contacts.Form = (function() { | |||
| delIcon.setAttribute('role', 'button'); | |||
| delIcon.className = 'icon-delete'; | |||
| delButton.appendChild(delIcon); | |||
| delButton.onclick = function removeElement(event) { | |||
| delButton.onmousedown = function removeElement(event) { | |||
There was a problem hiding this comment.
I'm kind of worried of this. That would make it easy to delete a phone number just by scrolling :/
There was a problem hiding this comment.
You are right.. :( But I can't think on another solution. Ideas?
…etun Using clientX and clientY instead mousedown Adding a comment with the bug
albertopq
added a commit
that referenced
this pull request
Nov 7, 2012
Bug 796432 - Avoiding remove a phone when clicking RETURN key
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final fix would be adding a NEXT key in the keyboard, but this patch will at least fix the weird behavior of adding/removing a phone when clicking return