Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Bug 804539 - [cards view] holding the home button while opened adds all running apps again #5953

Merged
merged 1 commit into from
Oct 28, 2012
Merged

Bug 804539 - [cards view] holding the home button while opened adds all running apps again #5953

merged 1 commit into from
Oct 28, 2012

Conversation

ttaubert
Copy link
Contributor

No description provided.

@@ -270,7 +276,7 @@ var CardsView = (function() {
}

function cardSwitcherIsShown() {
return cardsView.classList.contains('active');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we change checking for the class to flag, do we need additional function just for returning it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we really need a function for that. I just wanted to keep the current public API:

https://github.com/ttaubert/gaia/blob/24f264ccb13a74f9bf49ae7d4d7ec780cd835a6a/apps/system/js/cards_view.js#L561

Should I remove this? I don't see any clients of this API anyway.

@ghost ghost assigned michalbe Oct 23, 2012
vingtetun added a commit that referenced this pull request Oct 28, 2012
…n-twice

Bug 804539 - [cards view] holding the home button while opened adds all running apps again
@vingtetun vingtetun merged commit 22a6e30 into mozilla-b2g:master Oct 28, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants