This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 817039 - Merge latest gaia-ui-tests to gaia, r=lightsofapollo, a=tes... #6793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| findAndRemoveContact: function(cdata){ | ||
| var options = {filterBy: ["familyName"], | ||
| filterOp: "contains", |
There was a problem hiding this comment.
Can you define as:
var options = {
myvar: x,
...
};
|
@jonallengriffin r=lightsofapollo assuming small nits are fixed. I mentioned this before but this is awesome, its great to see all these tests! |
|
@lightsofapollo, this addresses the code duplication issue by removing gaia_unlock.js, and updating app_integration.js to use gaia_lock_screen.js instead. Can you confirm the changes look ok to you? |
|
@jonallengriffin Thanks for killing the other unlock script! r=me. please merge (assuming tests passing) if you can't merge I will be back in a moment... |
jonallengriffin
pushed a commit
that referenced
this pull request
Dec 4, 2012
Bug 817039 - Merge latest gaia-ui-tests to gaia, r=lightsofapollo, a=tes...
|
Tests pass, merged. |
sashakruglov
pushed a commit
to sashakruglov/gaia-ui-tests
that referenced
this pull request
Dec 8, 2013
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...t-only
This PR updates Gaia's copy of gaia-ui-tests with the latest. Most of these are Python changes, but there are a few atom changes as well.