Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

[Bug 822630] [contacts] Possible CSP problems #7108

Merged
merged 1 commit into from

3 participants

Jose M. Cantera Antonio M. Amaya Francisco Jordano
Jose M. Cantera
Collaborator

No description provided.

Francisco Jordano arcturus commented on the diff
apps/communications/contacts/oauth2/dialogs_end.html
@@ -13,13 +13,10 @@
<html>
<head>
<meta charset="UTF-8">
- <script src="oauth2/js/parameters.js"></script>
+ <script src="js/parameters.js"></script>
+ <script src="js/dialogs_end_init.js"
Francisco Jordano Collaborator

we are missing |>|

Francisco Jordano Collaborator

and < / script >

Jose M. Cantera Collaborator

oh yeah, last minute syntax error. that's a heads-up I should go on vacation right now! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Jose M. Cantera
Collaborator

@arcturus syntax error fixed. Antonio is going to review as Carmen is on vacation

Antonio M. Amaya

This looks good to me, @jmcanterafonseca

Jose M. Cantera
Collaborator

@arcturus just waiting for a+ for this small patch.

thanks!

Jose M. Cantera jmcanterafonseca merged commit 5566427 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 20, 2012
  1. Jose M. Cantera
This page is out of date. Refresh to see the latest.
2  apps/communications/contacts/index.html
View
@@ -241,7 +241,7 @@ <h2 data-l10n-id="social-network" id="social-label">Social Network</h2>
<h2>#type#</h2>
<div class="item">
<div class="item-body-exp">
- <a href="javascript: void(0);" class="action action-block">
+ <a href="#" class="action action-block">
<span role="button" class="icon-address" data-l10n-id="legendAddress">Address</span>
<b>
<span>#streetAddress#</span>
9 apps/communications/contacts/oauth2/dialogs_end.html
View
@@ -13,13 +13,10 @@
<html>
<head>
<meta charset="UTF-8">
- <script src="oauth2/js/parameters.js"></script>
+ <script src="js/parameters.js"></script>
+ <script src="js/dialogs_end_init.js"></script>
Francisco Jordano Collaborator

we are missing |>|

Francisco Jordano Collaborator

and < / script >

Jose M. Cantera Collaborator

oh yeah, last minute syntax error. that's a heads-up I should go on vacation right now! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
</head>
<body>
- <script>
- window.opener.postMessage('closed',
- fb.oauthflow.params['contactsAppOrigin']);
- window.close();
- </script>
+ </body>
</html>
4 apps/communications/contacts/oauth2/flow.html
View
@@ -16,8 +16,6 @@
<body>
<script src="js/flow.js"></script>
<script src="js/parameters.js"></script>
- <script>
- fb.oauthflow.init();
- </script>
+ <script src="js/flow_init.js"></script>
</body>
</html>
4 apps/communications/contacts/oauth2/js/dialogs_end_init.js
View
@@ -0,0 +1,4 @@
+'use strict';
+
+window.opener.postMessage('closed', fb.oauthflow.params['contactsAppOrigin']);
+window.close();
3  apps/communications/contacts/oauth2/js/flow_init.js
View
@@ -0,0 +1,3 @@
+'use strict';
+
+fb.oauthflow.init();
Something went wrong with that request. Please try again.