This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 826293 Pick Contact Activity is broken if the Contact has more than ... #7294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No idea how to test it :D, can you explain me the steps to follow? |
|
add a new contact with two phone numbers, let it be C. open the SMS app, click on '+', then click on the 'person' icon. The contacts app should be opened. In the contacts app, choose the contact C, a select dialog with the two numbers should be open and it should allow you to select one of the phone numbers of your contact. Once you select one it should appear in the SMS app as destination number. |
|
|
||
| section.valueselector [role="dialog"] li input { | ||
| left: 0; | ||
| .valueselector { |
There was a problem hiding this comment.
Are we keeping this CSS file only for this bunch of rules?
I suggest to move them to contacts.css
As soon as we perform this change r+ from my side
…an one Phone Number
|
R+, BB+ ... landing! |
jmcanterafonseca
added a commit
that referenced
this pull request
Jan 5, 2013
Bug 826293 Pick Contact Activity is broken if the Contact has more than ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...one Phone Number