[Bug 826085 ][B2G] [SMS] Contacts : SMS message deleted when choosing contact for sea... #7394
Conversation
|
There are some small changes coming, I will ping u again when ready! |
|
@steveck-chung Code ready for reviewing! All @aymanmaat suggestions added.r? |
|
I will squash after the review! |
| @@ -44,6 +44,7 @@ no-results = No results returned | |||
|
|
|||
| # Modal Dialogs | |||
| resend-confirmation = The message could not be sent. Try again? | |||
| resend-confirmation = The message could not be sent. Try again? | |||
There was a problem hiding this comment.
Why we need a duplicate string here...? Is this new string for discard sms (discard-sms)?
There was a problem hiding this comment.
Arrr, my fault! I dont know why it's not in the commit :S. Updating!
|
Summary. I've been talking with @aymanmaat and we agree with your comment #7394 (comment) , so now the user will be asked to discard the message if the input it's not empty in both cases (new message / new message inside a thread). All your suggestions are added, r? |
|
All commits squashed and I've updated the commit name with the reviewer. |
| @@ -43,6 +43,7 @@ carrier-unknown = Carrier unknown | |||
| no-results = No results returned | |||
|
|
|||
| # Modal Dialogs | |||
| discard-sms = Are you sure you want to discard this message? | |||
There was a problem hiding this comment.
nit, would you align the = sign with the rest please?
There was a problem hiding this comment.
Done. Thanks for the review @fabi1cazenave !
|
Except for the button status, I think the rest of part is ok for me. You can ping me if you still unable to reproduce the issue. |
…search or contact list r=steveck-chung r=kaze
|
@steveck-chung Button status fixed! Sorry for the delay I was reviewing other patch! |
[Bug 826085 ][B2G] [SMS] Contacts : SMS message deleted when choosing contact for sea...
...rch or contact list