This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 872054 - [Inari] Busy line tone is heard through the speaker (r=etiennesegonzac) #9818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhford
added a commit
that referenced
this pull request
May 17, 2013
…ne-on-speaker Bug 872054 - [Inari] Busy line tone is heard through the speaker (r=etiennesegonzac)
jhford
added a commit
that referenced
this pull request
May 17, 2013
…ne-on-speaker Bug 872054 - [Inari] Busy line tone is heard through the speaker (r=etiennesegonzac)(cherry picked from commit 57568a2)
|
Sorry, I accidentally merged this before it was R+'d. Please merge this manually. |
| @@ -164,7 +164,7 @@ var KeypadManager = { | |||
| this.hangUpCallFromKeypad); | |||
| } | |||
|
|
|||
| TonePlayer.init(); | |||
| TonePlayer.init(this._onCall ? 'telephony' : 'ringer'); | |||
There was a problem hiding this comment.
I think we want to leave it to default when not oncall (ie. not setting a specific audio channel)
There was a problem hiding this comment.
Agreed! I'll try to include this change ASAP since I am in Madrid and I forgot my laptop back in Barcelona... :-( Since next Monday is a bank day in Barcelona and I won't be back until Monday night, I'll try to talk to someone in Monday to resend the pull request for me... ;-)
|
@gtorodelvalle this is ok to merge! |
|
I'll merge it since this PR is closed :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We set the 'mozAudioChannelType' to 'telephony' when playing the busy tone.