This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 860696: add bt test commands. r=echou #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "'bt remote add [<bd_addr>]':\r\n" | ||
| "Add a remote device to the scatternet where the device specified by <bd_addr>\r\n" | ||
| "lives and return the address of the newly created device. If <bd_addr> is\r\n" | ||
| "omitted, Bluetooth LOCAL address ff:ff:ff:00:00:00 is assumed.\r\n", |
There was a problem hiding this comment.
Allowing to specify a <bd_addr> here is kind of misleading because all operations should be limited in the same scatternet now. No matter what address we have here, except those invalid ones, we add a new remote device in current scatternet anyway. So why bother? I'm going to remove it in the next revision.
|
|
Somehow I can't see your comments. Could you comment directly on https://github.com/mozilla-b2g/platform_external_qemu/pull/57/files ? |
|
@eric30, Somehow I can't see your comments. Could you comment directly on https://github.com/mozilla-b2g/platform_external_qemu/pull/57/files ? |
|
|
||
| static int | ||
| do_bt_remote_remove_device( ControlClient client, struct bt_device_s *dev, | ||
| int fatal ) |
|
Rebase and address above review comments. |
vicamo
added a commit
that referenced
this pull request
Mar 25, 2014
Bug 860696: add bt test commands. r=echou
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.