Bug 1328659 - Add support for utf8=utf8mb4 (switches to dynamic/compressed row format, and changes charset to utf8mb4) ❤️ #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanwh
changed the title
dklawren
previously requested changes
Jul 9, 2018
Bugzilla/DB/Mysql.pm
Outdated
| = $global{innodb_file_format} eq 'Barracuda' | ||
| && $global{innodb_file_per_table} eq 'ON' | ||
| && $global{innodb_large_prefix} eq 'ON'; | ||
|
|
There was a problem hiding this comment.
2 space or more indent here please.
Bugzilla/Config/General.pm
Outdated
| default => '0', | ||
| type => 't', | ||
| choices => [ '1', 'utf8', 'utf8mb4' ], | ||
| default => 'utf8', |
There was a problem hiding this comment.
Should be instead:
type => 's',
choices => [ 'utf8', 'utf8mb4' ],
default => 'utf8',
dylanwh
commented
Jul 10, 2018
| AND TABLE_COLLATION NOT LIKE 'utf8%' | ||
| LIMIT 1", undef, $db_name); | ||
| AND TABLE_COLLATION != ? | ||
| LIMIT 1", undef, $db_name, $collate); |
There was a problem hiding this comment.
@dklawren this is one of those changes I talked about. Before it was a prefix match against 'utf8', so if it was utf8mb4_unicode_blah, it would still match. In prod it appears it is only utf8_general_ci
|
Checked out the latest changes and after restart of DB everything checked out. r=dkl |
dylanwh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.