landing_job: add landed_revisions field (bug 1834885) #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zzzeid
commented
May 25, 2023
•
zzzeid
commented
- add diff_id to revision_landing_job table
- add method to set diff IDs and call it at landing time
- add landed_revisions helper method to fetch revision_to_diff_ids
- add a test that lands two versions of a revision
- fix variable names in transplants.warning_previously_landed
zzzeid
changed the base branch from
main
to
zeid/bug-1834868-fix-key-error-revisions
zzzeid
changed the title
zzzeid
force-pushed
the
zeid/bug-1834885-track-diff-id-on-landing-receipt
branch
3 times, most recently
from
45ab553
to
cbaf7ce
Compare
zzzeid
changed the title
zzzeid
force-pushed
the
zeid/bug-1834885-track-diff-id-on-landing-receipt
branch
from
cbaf7ce
to
f2d488c
Compare
- add diff_id to revision_landing_job table - add method to set diff IDs and call it at landing time - add landed_revisions helper method to fetch revision_to_diff_ids - add a test that lands two versions of a revision - fix variable names in transplants.warning_previously_landed
zzzeid
force-pushed
the
zeid/bug-1834885-track-diff-id-on-landing-receipt
branch
from
f2d488c
to
843c134
Compare
zzzeid
commented
May 25, 2023
cgsheeh
requested changes
May 26, 2023
Co-authored-by: Connor Sheehan <cosheehan@mozilla.com>
zzzeid
changed the title
cgsheeh
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.