Rename the rally output file #95
Conversation
|
cc @rhelmer |
No Taskcluster jobs started for this pull requestThe `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request. |
There was a problem hiding this comment.
We'll need a PR to rename in https://github.com/mozilla-extensions/rally-core-addon/blob/master/package.json before this will work. Other than that it looks good, thank you!
We're renaming in this PR. Once we cut a new release following our process, the updates will get to the @escapewindow does this PR need to block on us cutting a release? We're aware we won't be able to release anything until we update our clone repo. |
|
If we land this before the package is renamed, CI will be broken in this repo until it is renamed. Let's rename in both locations at approximately the same time. |
Oh, in the |
The repository was renamed to rally-core-addon, while the addon id and the name of generated artifact is currently still the same. It will change in the near future.
|
this will need to be rebased upon: https://github.com/mozilla-extensions/xpi-manifest/blob/master/manifests/rally-core-addon.yml |
Thanks, I'll take care of it. |
Dexterp37
force-pushed
the
rename_rally_file
branch
from
6dd465c
to
82aa9db
Compare
|
@escapewindow this is now ready for another look/merge. I'll be merging the change in the core-addon repo as soon as this gets merged! |
|
We need to merge mozilla-extensions/rally-core-addon#12 before this can land. |
This was merged :) |
This is a follow up to #92 and to the requested changes on mozilla-rally/rally-core-addon#271
The artifact name was renamed, so we can now change it too. The new name will be picked up by the clone in
mozilla-extensionas soon as we cut a new release.