Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Roboto font #67 #72

Closed
wants to merge 1 commit into from
Closed

Add Roboto font #67 #72

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 21, 2018

No description provided.

@ghost ghost mentioned this pull request Sep 21, 2018
@ghost
Copy link
Author

ghost commented Sep 21, 2018

@armenzg Is legend.css is the file, where I have to add CSS changes?

@ghost
Copy link
Author

ghost commented Sep 22, 2018

I have tried adding the @font-face and font-family in legend.css. But, I couldn't see the changes being iterated over there in the page. @armenzg could you please let me know, how should I proceed further?

@ghost ghost mentioned this pull request Sep 24, 2018
@armenzg
Copy link
Contributor

armenzg commented Sep 24, 2018

Hi @Soundharyaam I'm happy to give some pointers but this is basic HTML knowledge. Perhaps a quick tutorial on HTML would help you in contributing more effectively.

In any case, if you use the devtools you can see that I changed the font-family to Arial and it works:
image

This is what you should add to the CSS:

font-family: 'Roboto', sans-serif;

Telling you exactly where to write that would defeating the purpose of you getting to learn so I can't tell you more than that. Try few things and document them in a comment. That way I can see what you have tried.

@armenzg
Copy link
Contributor

armenzg commented Sep 26, 2018

A fix for this just landed:
7ef243d

@armenzg armenzg closed this Sep 26, 2018
@djmitche
Copy link

@Soundharyaam Sorry this got closed out from under you! Can we help you find another way to contribute?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants