Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Roboto font #67

Closed
armenzg opened this issue Sep 20, 2018 · 6 comments
Closed

Add Roboto font #67

armenzg opened this issue Sep 20, 2018 · 6 comments
Labels
good first issue Good for newcomers

Comments

@armenzg
Copy link
Contributor

armenzg commented Sep 20, 2018

We’re currently using the default font, however, I would like us to use Roboto Sans.

You can see how a different font got added in here:
mozilla-frontend-infra/firefox-health-dashboard@9ff6b2e
@armenzg armenzg added the good first issue Good for newcomers label Sep 20, 2018
@ghost
Copy link

ghost commented Sep 20, 2018

Hi, Can I work on this issue?

@ghost
Copy link

ghost commented Sep 20, 2018 •
edited by ghost

PR : #72

@ghost
Copy link

ghost commented Sep 21, 2018

@armenzg I have made the PR. Could you please review this?

@aimenbatool
Copy link
Contributor

Hi @armenzg, Is this issue solved or still available?

aimenbatool added a commit to aimenbatool/js-perf-dashboard that referenced this issue Sep 25, 2018
@aimenbatool
Issue mozilla-frontend-infra#67 - Add Roboto font
b2ae630
aimenbatool added a commit to aimenbatool/js-perf-dashboard that referenced this issue Sep 25, 2018
@aimenbatool
Issue mozilla-frontend-infra#67 - Add Roboto font | Use index.css file
3613e24
@aimenbatool
Copy link
Contributor

Hi @armenzg, I have solved this issue and opened a pull request #75. Can you please check and merge that?

aimenbatool added a commit to aimenbatool/js-perf-dashboard that referenced this issue Sep 26, 2018
@aimenbatool
Issue mozilla-frontend-infra#67 - Use withStyles method to add Roboto…
0d81a23 
… font
armenzg pushed a commit that referenced this issue Sep 26, 2018
@aimenbatool @armenzg
Issue #67 - Add Roboto font (#75)
7ef243d
@armenzg
Copy link
Contributor Author

armenzg commented Sep 26, 2018

This just got fixed:
#77

Thank you!

@armenzg armenzg closed this as completed Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@armenzg @aimenbatool