Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #67 - Add Roboto font #75

Merged
merged 3 commits into from
Sep 26, 2018

Conversation

aimenbatool
Copy link
Contributor

I have added a link to google font and then in index.jsx file I set font family equals to Roboto.

@armenzg can you please check and let me know if there is any better way to do this task?
Thanks,

@aimenbatool aimenbatool mentioned this pull request Sep 25, 2018
Copy link
Contributor

@armenzg armenzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, however, I want to stay away from .css files.

Could you please use withStyles (as in your other PR) instead of a .css file?

Thank you!

@aimenbatool
Copy link
Contributor Author

I have updated Roboto font using withStyles method. Please review it now.

Copy link
Contributor

@armenzg armenzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You got it!
Many thanks 👍

@armenzg armenzg merged commit 7ef243d into mozilla-frontend-infra:master Sep 26, 2018
@aimenbatool
Copy link
Contributor Author

Thanks, @armenzg. 🙋
I appreciate your time and support at the beginning of my journey to Open Source.
Means A lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants