Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prompt usage has been disabled in 1.1.3 for auto-login | Proposals to fix prompt usage in a future NLX version #91

Closed
gdestuynder opened this issue Mar 22, 2018 · 2 comments

Comments

@gdestuynder
Copy link
Contributor

See also: #87 where prompt was disabled for NLX 1.1.3

TLDR:

  • RP GET /authorize.. 302
  • ... GET /login
  • we detect there is no prompt setting and that we should try autologin and we 302
  • .. GET /authorize?prompt=none
  • Account is a Google account, auth0 302 to google
  • GET google.com/authorize?prompt=none <= promp param is forwarded by auth0 here
  • google 302 to auth0 callback with access_denied code (which is not a valid OpenID Connect code)
  • auth0 302 to the RP forwarding the error code
  • User is stuck/ can't login

Possible fixes:
A) Google sends a valid error code such as login_required or interaction_required and auth0 sees it, then retries with prompt=login (this might already work, but I haven't tested) (most preferred)

B) We disable the Google social connector, add a new custom connector that uses Google OIDC and drop the prompt= param ourselves, or handle the return code ourselves

C) We don't follow standard and don't implement prompt (least preferred)
Note:
GitHub may suffer from the same issue, not tested.

@gene1wood
Copy link
Contributor

Another fix to explore

D) Contact Auth0 support to ask if there's any way to configure Auth0 to not pass on the prompt=none argument to the Google IDP

@gdestuynder gdestuynder changed the title NLX 1.1.3 - re-try to use prompt param for autologin prompt usage has been disabled in 1.1.3 for auto-login | Proposals to fix prompt usage in a future NLX version Apr 2, 2018
@hidde
Copy link
Contributor

hidde commented May 23, 2018

This has been fixed with solution (C) because it was needed to make autologin work with Firefox Accounts. That has also fixed the issue for Google.

Closing this for now, certainly happy to review/improve at a later stage.

@hidde hidde closed this as completed May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants