Update favicon (fixes #281) #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hidde de Vries <hidde@hiddedevries.nl>
This was referenced Jan 11, 2019
|
Planned for 2018-01-14 to sync with SSO Dashboard deploy |
gene1wood
approved these changes
Jan 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Gene,
Would you be able to review and release this update?
It changes the NLX favicon to be a lock instead of the Mozilla m. This is part of a broader plan that also updates favicons in SSO Dashboard mozilla-iam/sso-dashboard#354 and DinoPark (Jira DP-948 / mozilla/mozillians#3222), in line with the Mozilla-wide Protocol design system.
cc @mbransn @hmitsch
fixes #281