Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.1.4 #92

Merged
merged 5 commits into from Mar 26, 2018
Merged

Release 1.1.4 #92

merged 5 commits into from Mar 26, 2018

Conversation

hidde
Copy link
Contributor

@hidde hidde commented Mar 26, 2018

  • Added polyfill for localStorage (this fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1448284)
  • Did a quick fix that makes sure the heading in an error page always takes up some space (it seems that new Auth0.js throws errors differently, the headings are no longer passed the same way)

Signed-off-by: Hidde de Vries <hidde@hiddedevries.nl>
Signed-off-by: Hidde de Vries <hidde@hiddedevries.nl>
Signed-off-by: Hidde de Vries <hidde@hiddedevries.nl>
Signed-off-by: Hidde de Vries <hidde@hiddedevries.nl>
Signed-off-by: Hidde de Vries <hidde@hiddedevries.nl>
@hidde hidde requested a review from gdestuynder March 26, 2018 09:25
Copy link
Contributor

@gdestuynder gdestuynder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I though this was already polyfilled somehow. might be scoped to a library though

@gdestuynder gdestuynder merged commit 415f1ee into master Mar 26, 2018
@hidde hidde deleted the release/1.1.4 branch April 5, 2018 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants