Pin lua-resty-openidc to version 1.6.1 #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround lua-resty-openidc bug zmartzone/lua-resty-openidc#249
|
@gdestuynder I encountered the bug described in zmartzone/lua-resty-openidc#249 in MozDef. I entered the mozilla.oidc.accessproxy docker container and downgraded the module I HUP'd nginx and the problem was resolved. |
gene1wood
added a commit
to gene1wood/MozDef
that referenced
this pull request
Mar 21, 2019
This gets us mozilla-iam/mozilla.oidc.accessproxy#36 which works around the bug in zmartzone/lua-resty-openidc#249
|
@gene1wood thanks - have you tried their setting idea as well? |
gdestuynder
approved these changes
Mar 21, 2019
I've not, maybe after going back to 1.6.1 we can see how to move forward with their idea |
gene1wood
added a commit
to gene1wood/MozDef
that referenced
this pull request
Mar 22, 2019
Now that mozilla-iam/mozilla.oidc.accessproxy#36 is merged to master and built and uploaded to dockerhub as tag `latest` we can go back to using latest. Note that in mozilla#1155 I updated the nginx container but missed the nginxkibana container which should have also been pinned to 8334f96 dockerhub tag resulting in only one of the two mozilla.oidc.accessproxy containers we use to work correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround lua-resty-openidc bug zmartzone/lua-resty-openidc#249