Import mozilla-mobile/fenix quarantine. #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename shortcuts to search engine on search screen * Remove deprecated pref key * Re-add deprecated string X-Channel-Revision: [master] mozilla-mobile/android-components@1321b1d X-Channel-Converted-Revision: [master] mozilla-mobile/fenix@b7325a3 X-Channel-Revision: [master] mozilla-mobile/firefox-tv@e8ccd59 X-Channel-Revision: [main] MozillaReality/FirefoxReality@e52556c X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@7243b05
Delphine
requested changes
Jul 27, 2020
| @@ -1454,12 +1454,14 @@ | |||
| <string name="top_sites_max_limit_confirmation_button">OK, Got It</string> | |||
|
|
|||
| <!-- DEPRECATED STRINGS --> | |||
There was a problem hiding this comment.
@eliserichards What would be best here would be to just delete all those depecrated strings. Does that make sense to you as well?
thanks
There was a problem hiding this comment.
@BranescuMihai: I think Elise is out, would you mind removing all the deprecated strings so I can expose all the strings this weekend to localizers please? (so, the ones landed by Elise as well as the new one from 7fa41a2)
The rest is good to go!
mozilla-l10n-automation-bot
force-pushed
the
fenix-quarantine
branch
28 times, most recently
from
ed5876c
to
86cf3f5
Compare
mozilla-l10n-automation-bot
force-pushed
the
fenix-quarantine
branch
8 times, most recently
from
e9ea870
to
0d3e818
Compare
X-Channel-Revision: [master] mozilla-mobile/android-components@1321b1d X-Channel-Converted-Revision: [master] mozilla-mobile/fenix@bfc955c X-Channel-Revision: [master] mozilla-mobile/firefox-tv@e8ccd59 X-Channel-Revision: [main] MozillaReality/FirefoxReality@e52556c X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@7243b05
X-Channel-Revision: [master] mozilla-mobile/android-components@1321b1d X-Channel-Converted-Revision: [master] mozilla-mobile/fenix@5d1aeb5 X-Channel-Revision: [master] mozilla-mobile/firefox-tv@e8ccd59 X-Channel-Revision: [main] MozillaReality/FirefoxReality@e52556c X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@7243b05
X-Channel-Revision: [master] mozilla-mobile/android-components@1321b1d X-Channel-Converted-Revision: [master] mozilla-mobile/fenix@ff50dae X-Channel-Revision: [master] mozilla-mobile/firefox-tv@e8ccd59 X-Channel-Revision: [main] MozillaReality/FirefoxReality@e52556c X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@7243b05
Delphine
requested changes
Jul 31, 2020
| @@ -1454,12 +1454,14 @@ | |||
| <string name="top_sites_max_limit_confirmation_button">OK, Got It</string> | |||
|
|
|||
| <!-- DEPRECATED STRINGS --> | |||
There was a problem hiding this comment.
@BranescuMihai: I think Elise is out, would you mind removing all the deprecated strings so I can expose all the strings this weekend to localizers please? (so, the ones landed by Elise as well as the new one from 7fa41a2)
The rest is good to go!
mozilla-l10n-automation-bot
force-pushed
the
fenix-quarantine
branch
from
7fa41a2
to
fdf9559
Compare
BranescuMihai
added a commit
to BranescuMihai/fenix
that referenced
this pull request
Aug 1, 2020
As requested here: mozilla-l10n/android-l10n#249 (comment)
4 tasks
mozilla-l10n-automation-bot
force-pushed
the
fenix-quarantine
branch
11 times, most recently
from
d7c5547
to
3d64ae5
Compare
As requested here: mozilla-l10n#249 (comment) X-Channel-Revision: [master] mozilla-mobile/android-components@1321b1d X-Channel-Converted-Revision: [master] mozilla-mobile/fenix@3cb1acc X-Channel-Revision: [master] mozilla-mobile/firefox-tv@e8ccd59 X-Channel-Revision: [main] MozillaReality/FirefoxReality@e52556c X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@7243b05
eliserichards
pushed a commit
to mozilla-mobile/fenix
that referenced
this pull request
Aug 3, 2020
As requested here: mozilla-l10n/android-l10n#249 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
n/t