Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

FNX-14372 ⁃ bugfix/Remove all deprecated strings #13192

Conversation

BranescuMihai
Copy link
Contributor

@BranescuMihai BranescuMihai commented Aug 1, 2020

As requested here: mozilla-l10n/android-l10n#249 (comment)

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2020

Codecov Report

Merging #13192 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #13192      +/-   ##
============================================
- Coverage     28.23%   28.22%   -0.02%     
  Complexity     1029     1029              
============================================
  Files           418      418              
  Lines         16808    16808              
  Branches       2182     2182              
============================================
- Hits           4746     4744       -2     
- Misses        11717    11719       +2     
  Partials        345      345              
Impacted Files Coverage Δ Complexity Δ
...mponents/searchengine/FenixSearchEngineProvider.kt 62.16% <0.00%> (-1.81%) 13.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76d49fc...27faec9. Read the comment docs.

@eliserichards
Copy link
Contributor

Fixes #13226

@eliserichards eliserichards merged commit 3cb1acc into mozilla-mobile:master Aug 3, 2020
@data-sync-user data-sync-user changed the title bugfix/Remove all deprecated strings FNX-14372 ⁃ bugfix/Remove all deprecated strings Aug 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants