Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an exception for alerts #176

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Conversation

Delphine
Copy link
Contributor

@Delphine Delphine commented Dec 2, 2022

No description provided.

@Delphine Delphine requested a review from a team as a code owner December 2, 2022 02:06
@Delphine Delphine requested a review from flodolo December 2, 2022 02:07
@flodolo flodolo merged commit 450c838 into mozilla-l10n:main Dec 2, 2022
@flodolo
Copy link
Contributor

flodolo commented Dec 2, 2022

Is there a technical reason of that string not using a placeholder?

@Delphine
Copy link
Contributor Author

Delphine commented Dec 2, 2022

Nope. I just thought it would be OK to leave as is in this case (as it sometimes is)
I can revert that though, if it's better to use a placeholder.

@flodolo
Copy link
Contributor

flodolo commented Dec 2, 2022

Your call. In general, I think the rule of thumb should be "Should this string still say Firefox in a repackaged and rebranded browser?".

@flodolo
Copy link
Contributor

flodolo commented Dec 2, 2022

(the counter example would be a string like "Firefox Account", where it's always going to be Firefox)

@Delphine Delphine deleted the change branch December 2, 2022 18:41
@Delphine Delphine restored the change branch December 2, 2022 18:41
@Delphine
Copy link
Contributor Author

Delphine commented Dec 2, 2022

I see what you mean, I understood that in some cases it was just OK to leave as is, if it's not too user facing and part of longer sentences (can't find the doc anymore, but you probably wrote it ;) )
Here it may be better to actually use a placeholder, you're right (and it is a user facing string)... I'll just revert this

@flodolo
Copy link
Contributor

flodolo commented Dec 2, 2022

Here it may be better to actually use a placeholder, you're right (and it is a user facing string)... I'll just revert this

It's better to revert after the updated string lands, to avoid constant failure of the linter ;-)

@Delphine
Copy link
Contributor Author

Delphine commented Dec 2, 2022

ok! will do it in that order then :)

@Delphine Delphine deleted the change branch December 6, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants